Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: countly general implementation fixes (WPB-14941) 🍒 #3733

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-14941 [Android] Disable Countly Views temporarily


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Countly general fixes:

  • Remove usage of halt() function, this was causing crashes as the instance it was being cleared when a second user without consent was being logged in. The proper way to do it is by using following these instructions

  • Disable view tracking, we will renable in the future, added a feature flag for it.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS labels Dec 11, 2024
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3733.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3733.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@vitorhugods vitorhugods added this pull request to the merge queue Dec 15, 2024
Merged via the queue into develop with commit a59ff2e Dec 15, 2024
12 of 13 checks passed
@vitorhugods vitorhugods deleted the fix/disable-view-tracking-countly-cherry-pick branch December 15, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants