Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for the next release, Refactor the container API #33

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Aug 17, 2023

Aligns #30 and #32 to shorten the code, and also updates the API from #30 to simplify their embedding into the existing tests without too many conversions

For the docs:

  • Reference the new features from README
  • Add page for the Go WireMock client
  • Add analytics links for wiremock.org where we try to get more insights on how the testcontainers are faring

FYI @walkerus @Vayras

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 17, 2023
@@ -0,0 +1,117 @@
dario.cat/mergo v1.0.0/go.mod h1:uNxQE+84aUszobStD9th8a29P2fMDhsBdgRYvZOxGmk=
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walkerus this file was not included. I normally include go.mod so that we have a kind of SBOM for commit tags, but would appreciate your opinion whether we want it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course, it should be included in the version control system, it looks like I forgot to do it

@oleg-nenashev oleg-nenashev merged commit c00ce20 into main Aug 17, 2023
1 check passed
@oleg-nenashev oleg-nenashev deleted the documentation-update-v7 branch August 17, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants