Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort pending api fetch if new search phrase entered; avoid too many api requests while typing #16

Open
wants to merge 9 commits into
base: stable-3_4_0
Choose a base branch
from

Conversation

GaziYucel
Copy link

  • the fetch method did a new api request for every keyup event
  • this made too many request
  • already pending fetch promise will be aborted if a new request is made

changes:

  • watcher searchPhrase removed
  • apiLookup method changed

@GaziYucel
Copy link
Author

In our discussion with Bozana, Devika and Alec, we found out that mapping of the languages are not correct as implemented by me. The main name in Ror is not always english. The mapping of OJS languages vs Ror languages are now better. One to one mapping, if a language not found than fall back to english and lastly to the main name in Ror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant