fix: prevent printing defineVars() into an inline style
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ematipico
approved these changes
Apr 12, 2024
matthewp
reviewed
Apr 12, 2024
| @@ -7,7 +7,7 @@ | |||
| "url": "https://github.com/withastro/compiler.git" | |||
| }, | |||
| "scripts": { | |||
| "build": "make wasm", | |||
| "build": "CGO_ENABLED=0 GOOS=js GOARCH=wasm go build \"-ldflags=-s -w\" -trimpath -o ./packages/compiler/wasm/astro.wasm ./cmd/astro-wasm/astro-wasm.go", | |||
There was a problem hiding this comment.
So that it isn't necessary to install make to contribute to the project, just pnpm and go.
lilnasy
changed the title
defineVars() into an inline scriptdefineVars() into an inline style
|
Can this be merged in the next release please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
define:varsnot working withis:inlinedirective in<style>tags #1000Testing
Docs