Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forced paint #2623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove forced paint #2623

wants to merge 2 commits into from

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Nov 22, 2024

Description

  • Fixes a forced paint currently affecting Astro docs, others.
  • I did this via the GH UI and haven't tested it myself, you've been warned!
Screen.Recording.2024-11-22.at.12.05.24.PM.mov

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 9faab85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 9faab85
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6740ea8bedef130008a92c2d
😎 Deploy Preview https://deploy-preview-2623--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 22, 2024
@FredKSchott
Copy link
Member Author

FredKSchott commented Nov 22, 2024

success! (I think)

Screen.Recording.2024-11-22.at.12.35.48.PM.mov

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.15 KB (-0.02% 🔽)
/_astro/*.js 22.41 KB (-0.01% 🔽)
/_astro/*.css 13.73 KB (0%)

@trueberryless
Copy link
Contributor

trueberryless commented Nov 23, 2024

There is currently a draft PR which moves the inline script into Page.astro because there are other restoration issues when overriding the sidebar.

Not sure how the maintainers will handle this, but I think we either wait for #2569 to merge or merge this one first and update the other PR...

"@astrojs/starlight": patch
---

Fix an issue where the scrollbar was causing a forced paint halfway through page render
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix an issue where the scrollbar was causing a forced paint halfway through page render
Fixes an issue where the scrollbar was causing a forced paint halfway through page render

Starlight and Astro prefer writing their changesets in a present tense verb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants