Removed scrollParentSelector and isInsideStaticContainer inputs that …

…are no longer used with new calculations.

Wrote changelog.

CHANGELOG.md

@@ -1,3 +1,13 @@
+<a name="0.6.0"></a>
+# 0.6.0
+
+### Breaking changes
+* Removed input parameters *scrollParentSelector* and *isInsideStaticContainer* as I believe these are no longer needed.
+
+### Features
+* Rewrote the zooming position calculations, it feels much more robust now and will hopefully perform as expected in
+more situations with complex layouts.
+
 <a name="0.5.1"></a>
 # 0.5.1
 

README.md

@@ -40,8 +40,6 @@ lensHeight | 100 | Height of the lens, if enabled.
 circularLens | false | Make the lens circular instead of square. This will only look good if width and height are equal.
 minZoomRatio | *baseRatio* | Lower limit on how much zoom can be applied with scrollZoom enabled. See below for details.
 maxZoomRatio | 2 | Upper limit on how much zoom can be applied with scrollZoom enabled. See below for details.
-scrollParentSelector | *none* | Selector of parent scrolling view as string. This avoid zoom gap with cursor when the scrolling view is not the main window. Example : `#scrolling-frame`
-isInsideStaticContainer | false | Set to `true` if the thumbnail is inside a container, to which `position: static` is applied (e.g. a modal window). This is required to avoid zoom position being calculated incorrectly.
 
 ### Zoom modes
 Mode | Description

src/lib/ngx-image-zoom.component.ts

@@ -1,4 +1,4 @@
-import { AfterViewInit, Component, ElementRef, EventEmitter, Input, OnChanges, OnDestroy, OnInit, Output, Renderer2, ViewChild } from '@angular/core';
+import { Component, ElementRef, EventEmitter, Input, OnChanges, OnDestroy, OnInit, Output, Renderer2, ViewChild } from '@angular/core';
 
 export interface Coord {
     x: number;
@@ -10,7 +10,7 @@ export interface Coord {
     templateUrl: './ngx-image-zoom.component.html',
     styleUrls: ['./ngx-image-zoom.component.css']
 })
-export class NgxImageZoomComponent implements OnInit, OnChanges, AfterViewInit, OnDestroy {
+export class NgxImageZoomComponent implements OnInit, OnChanges, OnDestroy {
 
     private static readonly validZoomModes: string[] = ['hover', 'toggle', 'click', 'hover-freeze'];
 
@@ -61,13 +61,10 @@ export class NgxImageZoomComponent implements OnInit, OnChanges, AfterViewInit,
 
     private latestMouseLeft: number;
     private latestMouseTop: number;
-    private scrollParent: Element;
-    private scrollParentSelector: string;
-    private isInsideStaticContainer = false;
 
     private eventListeners: (() => void)[] = [];
 
-    constructor(private renderer: Renderer2, private elRef: ElementRef) {
+    constructor(private renderer: Renderer2) {
     }
 
     @Input('thumbImage')
@@ -138,16 +135,6 @@ export class NgxImageZoomComponent implements OnInit, OnChanges, AfterViewInit,
         this.enableScrollZoom = Boolean(enable);
     }
 
-    @Input('scrollParentSelector')
-    public set setScrollParentSelector(selector: string) {
-        this.scrollParentSelector = selector;
-    }
-
-    @Input('isInsideStaticContainer')
-    public set setisInsideStaticContainer(isInStatic: boolean) {
-        this.isInsideStaticContainer = isInStatic;
-    }
-
     ngOnInit(): void {
         this.setUpEventListeners();
     }
@@ -164,12 +151,6 @@ export class NgxImageZoomComponent implements OnInit, OnChanges, AfterViewInit,
         this.calculateImageAndLensPosition();
     }
 
-    ngAfterViewInit(): void {
-        this.scrollParent = this.scrollParentSelector ?
-            document.querySelector(this.scrollParentSelector) :
-            this.elRef.nativeElement.parentElement;
-    }
-
     ngOnDestroy(): void {
         this.eventListeners.forEach((destroyFn) => destroyFn());
     }