[CLI] Force display mode if we fail to get an xpub w/ ledger #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,7 @@ pub trait HWI: Debug { | |||
| /// Get master fingerprint. | |||
| async fn get_master_fingerprint(&self) -> Result<Fingerprint, Error>; | |||
| /// Get the xpub with the given derivation path. | |||
| async fn get_extended_pubkey(&self, path: &DerivationPath) -> Result<Xpub, Error>; | |||
| async fn get_extended_pubkey(&self, path: &DerivationPath, display_mode: bool) -> Result<Xpub, Error>; | |||
There was a problem hiding this comment.
I would prefer that we do not modify the interface.
I think the possible fix is to add --display to the cli args for the Xpub command, and do
ledger.display_xpub(true) at the listing of devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit an issue while trying to get an xpub w/ a not 'standard' derivation path w/ the CLI:
Ledger devices have a 'security' features, if we want to get an xpub for a not 'standard' derivation path, we should use the
displaymode where the user add to ACK.Approach taken here is : if we fail to get an xpub w/ a ledger, we retry one more time w/
displaymode activated.