[GUI] Consider wallet to be syncing until first poll completes after opening #1377
+87
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp1ac4
added this to the v8 Liana - Wallet syncing / scanning state at wallet opening milestone
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
148fbe7
to
ea71a19
Compare
|
I moved some commits to #1370 as they also applied there (see #1370 (comment)). |
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
ea71a19
to
97c68a2
Compare
|
I added the |
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
97c68a2
to
5182af7
Compare
|
I changed to Draft as Cargo.toml is currently pointing to my branch for #1376 and will need to be reverted once that PR has been merged. |
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
5182af7
to
d9a495c
Compare
|
Updated liana dependency commit hash. |
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
d9a495c
to
8c51ffe
Compare
|
Rebased on master. |
jp1ac4
force-pushed
the
gui-check-last-poll
branch
2 times, most recently
from
13f4a49
to
adf15c4
Compare
This only applies to local backends.
If the user has imported a descriptor and is using bitcoind as a local node, then they will need to perform a rescan in order to see past transactions. Treating the wallet as syncing in this case could mislead the user that a rescan is being performed. Therefore, it's better to keep the past behaviour here to avoid further confusion.
jp1ac4
force-pushed
the
gui-check-last-poll
branch
from
adf15c4
to
9e1bb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the changes from #1376 to complete #1373.
It builds on the changes from #1370 to consider an existing wallet (that uses a local backend) to be syncing until the first poll completes after opening the GUI.