Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui(send): display max calculated amount w/ 8 decimals #1425

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pythcoiner
Copy link
Collaborator

fixes #1424
image

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Nov 6, 2024

It might look even nicer if you could use the amount_as_string function:

fn amount_as_string(a: Amount) -> String {

There would be some inconsistency with non-MAX recipients, but it might still look fine as those other amounts are editable. Perhaps later we could use this same formatting for all recipients somehow.

@pythcoiner
Copy link
Collaborator Author

done, ideed it's better.
image

Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7ab6d05

@edouardparis edouardparis merged commit 5133137 into wizardsardine:master Nov 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't trim trailing zeros on the send screen
4 participants