Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui(settings): add a button to copy auth fields & mask password #1432

Merged
merged 3 commits into from
Dec 20, 2024
Merged

gui(settings): add a button to copy auth fields & mask password #1432

merged 3 commits into from
Dec 20, 2024

Conversation

pythcoiner
Copy link
Collaborator

fixes #1160
image

@nondiremanuel nondiremanuel added GUI gui related Enhancement Improving an existing functionality Nice to have If it's not completed in time for the current version, it can be postponed labels Nov 5, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Nov 6, 2024

Wouldn't it be more consistent to use a clipboard icon as on other pages?

@pythcoiner
Copy link
Collaborator Author

done
image

@pythcoiner
Copy link
Collaborator Author

also replaced node password by stars since now we can copy it:

image

@pythcoiner pythcoiner changed the title gui(settings): make auth fields selectable for copy gui(settings): add a button to copy auth fields & mask password Nov 18, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Dec 19, 2024

Perhaps for consistency there should also be a clipboard icon for the Electrum server URL?

(This needs a rebase on master due to the DB migration.)

@jp1ac4 jp1ac4 self-requested a review December 19, 2024 09:19
@pythcoiner pythcoiner force-pushed the auth_selectable branch 2 times, most recently from 9ff98c7 to b5cf4ad Compare December 20, 2024 09:20
@pythcoiner
Copy link
Collaborator Author

image
done

jp1ac4
jp1ac4 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 9679f0f.

@edouardparis edouardparis merged commit ecce76a into wizardsardine:master Dec 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp1ac4 jp1ac4 jp1ac4 approved these changes

Assignees
No one assigned
Labels
Enhancement Improving an existing functionality GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Projects
Liana General
Status: Done
Milestone
v9 Liana - UI fixes and other
Development

Successfully merging this pull request may close these issues.

Settings > Bitcoin Core: password should be selectable
4 participants
@pythcoiner @jp1ac4 @edouardparis @nondiremanuel