Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liana gui to import liana directly #1473

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Nov 18, 2024

We import directly liana with the directory path instead of the git url.

@edouardparis edouardparis force-pushed the update-liana-gui-to-import-liana-directly branch from b7dcae1 to b0fbe08 Compare November 19, 2024 09:43
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b0fbe08.

Tested running GUI with both external and embedded lianad.

Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK 6cefd24
tested the reproducible build with this change

@edouardparis edouardparis merged commit 1454c11 into wizardsardine:master Nov 19, 2024
24 checks passed
@edouardparis edouardparis deleted the update-liana-gui-to-import-liana-directly branch November 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants