-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui: tx export feature #1496
base: master
Are you sure you want to change the base?
gui: tx export feature #1496
Conversation
d2b3874
to
4835465
Compare
output format is of this kind:
|
4835465
to
2f7d3bb
Compare
Maybe we should just stick to the transaction label (if present), in order to not over-complicate the logic and create confusion due to the fact that sometimes you can find the address label (if it was a single payment) while sometimes not (if it was a batch payment). For this kind of detail, the user could refer to the "payment export" which will be more related to this kind of information detail. What do you think? In such case the variable would be called "Tx Label" instead of a generic "Label" name. |
i'm fine w/ using only the Tx label, but i think we should keep |
I'm ok with it. |
700803d
to
d1e970a
Compare
9c6882c
to
0431b72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm continuing to test & review, but adding some initial comments.
0431b72
to
eebb785
Compare
3e92090
to
5309aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the export with a couple of wallets and it's looking good. Added some comments.
aeffc50
to
7ef4b7f
Compare
This needs a rebase on master. |
7ef4b7f
to
22f4875
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK 22f4875.
This PR add a feature to export transactions:
Done:
rfd
crate