Update rust-jsonrpc and switch to using minreq
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
changed the title
rust-jsonrpc and switch to using minreqrust-jsonrpc and switch to using minreq
darosior
force-pushed
the
update_jsonrpc
branch
2 times, most recently
from
ad9ddb7
to
0ad65d0
Compare
|
Alright so upstream was updated in apoelstra/rust-jsonrpc#103 apoelstra/rust-jsonrpc#102 to support everything we need. I updated this branch with a functional test exercising the request retry logic. |
|
Looks like nightly is broken.. |
|
Fixed the compilation issue on nightly (as per dtolnay/proc-macro2#356 (comment)) in #565. I'll rebase on top of it. |
darosior
changed the title
rust-jsonrpc and switch to using minreqrust-jsonrpc and switch to using minreq
|
Rebased, this is now ready for review. |
Instead of the hand-written HTTP implementation in the rust-jsonrpc library, use the minreq crate. It's a small, maintained, low dependency library actually focused on writing an HTTP client. This also reworks and better document the request retry logic.
|
ACK 43a0cf2 -- let's get it in early and try it as we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us take advantage of a more robust, but still lightweight, HTTP implementation.
This PR also cleanups our error handling code and adds a functional test checking we do retry request on transient bitcoind failures.