Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tracking of immature coinbase deposits #578

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Fix the tracking of immature coinbase deposits #578

merged 7 commits into from
Aug 1, 2023

Commits on Jul 20, 2023

  1. database: record whether a coin comes from an immature coinbase 

    We need to keep track of such coins to:
	- Track their maturation
	- Avoid using them (for instance in coin selection)

Reorg handling for coinbase deposits that become immature is not
implemented (yet). That's reasonable because:
1. It would be very unlikely that we'd move back, so it's most likely
   gonna be mature again immediately.
2. If there's a reorg of more than 100 blocks we've got bigger problems.
    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    26add29 View commit details
    Browse the repository at this point in the history

  2. commands: don't create spends with immature coins

    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    fd71712 View commit details
    Browse the repository at this point in the history

  3. commands: expose whether a coin is immature in listcoins

    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6ab6161 View commit details
    Browse the repository at this point in the history

  4. bitcoin: track maturity of coinbase deposits 

    We detect and store immature deposits (cause otherwise we won't go
through them again with listsinceblock), but mark them as such and
unconfirmed.
We only mark them as confirmed once they've matured. It's a bit clumsy
but it's not as if most of our users had coinbase deposits.
    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6b82894 View commit details
    Browse the repository at this point in the history

  5. qa: fix and improve the coinbase deposit functional test

    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    95dd3e5 View commit details
    Browse the repository at this point in the history

  6. qa: functional test createspend refuses immature outpoints

    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    289f658 View commit details
    Browse the repository at this point in the history

  7. qa: adapt the migration functional test to also support 1.0

    @darosior
    darosior committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    097d5e7 View commit details
    Browse the repository at this point in the history