Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: fix flaky test of unconfirmed spend RBF #824

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

darosior
Copy link
Member

Since #617 the spend info for a coin may be wiped from the DB. Be robust to a temporarily None spend info in the functional test.

See for instance https://github.com/wizardsardine/liana/runs/18785511349.

@darosior
Copy link
Member Author

ACK 6b5fc2d -- trivial and i've run this test a few dozen times concurrently locally to make sure it's unflaked.

@darosior darosior merged commit f512f3c into wizardsardine:master Nov 20, 2023
8 of 12 checks passed
@darosior darosior deleted the 2311_fix_flaky_test_spend branch November 20, 2023 13:57
@darosior darosior mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant