Fixed error thrown when converting collapsed range #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… range would cause an exception.
|
@wmaurer any chances on getting it in? Shouldn't be hard for you to review, while will reduce exceptions thrown by the extension. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by returning undefined instead of range instance when VSCode couldn't pick any word at given position.
Change in text returned in getSelectedText when there is no range is not necessary for this fix, but it will make the code more bulletproof in future.
As mentioned in #13 it looks also to fix #12, although I might be missing something in terms of error reproduction.
And by the way, thanks for nice extension! Definitely saved me some time.