Skip to content

Commit

Permalink
Implement VAR for C24_WMDE_Desktop_DE_06
Browse files Browse the repository at this point in the history
- new footer (SmallPrintFooter) component that has it's own colors+layout
- fix chevron color being too dark (->white again)
- add title attributes to links with explanations

https://phabricator.wikimedia.org/T375599
  • Loading branch information
moiikana authored and Abban committed Oct 16, 2024
1 parent be53d86 commit b16fc10
Show file tree
Hide file tree
Showing 15 changed files with 342 additions and 662 deletions.
4 changes: 3 additions & 1 deletion banners/desktop/C24_WMDE_Desktop_DE_06/banner_var.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { LocaleFactoryDe } from '@src/utils/LocaleFactory/LocaleFactoryDe';
// Channel specific form setup
import { createFormItems } from './form_items';
import { createFormActions } from '@src/createFormActions';
import { createFAQPageURL } from '@src/createFAQPageURL';

const date = new Date();
const localeFactory = new LocaleFactoryDe();
Expand All @@ -45,7 +46,8 @@ const app = createVueApp( BannerConductor, {
bannerProps: {
useOfFundsContent: localeFactory.getUseOfFundsLoader().getContent(),
remainingImpressions: impressionCount.getRemainingImpressions( page.getMaxBannerImpressions( 'desktop' ) ),
donationLink: createFallbackDonationURL( page.getTracking(), impressionCount )
donationLink: createFallbackDonationURL( page.getTracking(), impressionCount ),
faqPageLink: createFAQPageURL( page.getTracking() )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
</template>

<template #footer>
<BannerFooter @showFundsModal="isFundsModalVisible = true"/>
<SmallPrintFooter @showFundsModal="isFundsModalVisible = true" :faqPageLink="faqPageLink"/>
</template>

</MainBanner>
Expand Down Expand Up @@ -75,7 +75,7 @@ import { CloseEvent } from '@src/tracking/events/CloseEvent';
import { TrackingFeatureName } from '@src/tracking/TrackingEvent';
import ButtonClose from '@src/components/ButtonClose/ButtonClose.vue';
import colors from '../styles/colors';
import BannerFooter from '@src/components/Footer/BannerFooter.vue';
import SmallPrintFooter from '@src/components/Footer/SmallPrintFooter.vue';
enum ContentStates {
Main = 'wmde-banner-wrapper--main',
Expand All @@ -90,6 +90,7 @@ interface Props {
bannerState: BannerStates;
useOfFundsContent: useOfFundsContentInterface;
remainingImpressions: number;
faqPageLink: string;
}
defineProps<Props>();
Expand Down
11 changes: 4 additions & 7 deletions banners/desktop/C24_WMDE_Desktop_DE_06/styles/MainBanner.scss
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
@use 'src/themes/Mikings/variables/colors';

$banner-height: 357px !default;
$form-width: 300px !default;

.wmde-banner {
/*
Temporary fix until desktop banners use swatches.
Mobile theme color is used because`Svingle` theme does not have `_colors.scss` file
*/
--slider-chevron: #{colors.$black-light};

.previous {
--slider-chevron: var( --previous-button-fill );
}

&-main {
min-height: $banner-height;
Expand Down
47 changes: 0 additions & 47 deletions banners/desktop/C24_WMDE_Desktop_DE_06/styles/MainBannerVar.scss

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
$font-size: 14px
);
@use 'src/themes/Svingle/DonationForm/Forms/CustomAmountForm';
@use 'src/themes/Svingle/Footer/BannerFooter';
@use 'src/themes/Svingle/Footer/SmallPrintFooter';
@use 'src/themes/Svingle/Footer/SelectionInput';
@use 'src/themes/Svingle/Message/Message';
@use 'src/themes/Svingle/Slider/KeenSlider' with (
Expand Down
Loading

0 comments on commit b16fc10

Please sign in to comment.