feat!: set wdqs concept URI #771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting the concept URI of entities in WDQS explicitly and distinct from the hostname used to contact wikibase. This allows the concept URI to be a public URI while the wikibase hostname is the docker network internal hostname used to poll for updates. BREAKING CHANGE: env var WIKIBASE_CONCEPT_URI now mandatory to run image
Sets the WIKIBASE_CONCEPT_URI required by WDQS. #771 BREAKING CHANGE: changes the concept URI used in WDQS
rti
force-pushed
the
wdqs-separate-concept-uri
branch
from
4d7ed10
to
d4a0a96
Compare
rti
changed the title
lorenjohnson
reviewed
Oct 4, 2024
There was a problem hiding this comment.
This looks like it should go forward, and would be nice to backport. However, given the major versioning to 1.x and 2.x issue we've been talking about I wonder if there is any sensible way to maintain the current way it functions (even if not optimal or broken) so that it can be a minor release? 🤷🏼♂️
lorenjohnson
force-pushed
the
main
branch
4 times, most recently
from
e17ecc8
to
58a3ece
Compare
|
How to handle this versioning, as discussed today with @lorenjohnson WDQS bumps a major version
Deploy bumps a patch
TODO
|
|
holding back for #782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting the concept URI of entities in WDQS explicitly and distinct from the hostname used to contact wikibase.
This also fixes the problem WDQS not accepting entities when the wikibase host had a DNS name different from
wikibase(which should be always the case, becausewikibaseis not a FQDN).Note: In deploy, items and properties in WDQS will now have the public wikibase hostname with https protocol as prefix. E.g. https://wikibase.example/
Related:
wikibase.svc, I want it to belocalhost#385BREAKING CHANGE: env var WIKIBASE_CONCEPT_URI now mandatory to run wdqs updater