Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Normalize roll number to ensure uniformity #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DeepakSilaych
Copy link
Contributor

No description provided.

@Prater-12
Copy link
Collaborator

@DeepakSilaych registration related tests seem to be failing, although this is expected since roll numbers now have to be upper-case. Do also modify the test files to reflect the same.

@Prater-12
Copy link
Collaborator

Prater-12 commented Oct 28, 2023

Now this next comment goes for this and the other 2 pending pull requests you have made. You seem to have made all the commits to the same branch, and while the ProjectCard commit was only one commit along this chain, the rest have a lot more code than needed.

You will have to create separate branches for each issue, the only alternative being to make one big pull request, but we would rather not have that for many reasons. Here are some instructions on how you can go about this, courtesy of ChatGPT:

You can still create separate branches for each issue and push the commits related to each issue to their respective branches. Here are the steps:

  1. Create a New Branch:
    For each issue, create a new branch. Let's assume your current branch is main:

    git checkout main

    Now, create a new branch for the first issue:

    git checkout -b issue-1

    Repeat this process for each issue:

    git checkout main  # Switch back to main
    git checkout -b issue-2  # Create and switch to a new branch for the second issue

    Repeat the above command for each issue.

  2. Cherry-pick Commits:
    Now, you need to cherry-pick the relevant commits for each branch. Let's assume the commits for issue-1 are C1, C2, and C3. Replace these with the actual commit hashes:

    git checkout issue-1
    git cherry-pick C1 C2 C3

    Repeat this process for each branch and its respective commits.

  3. Push the Branches:
    After cherry-picking, you can push the branches to the remote repository:

    git push origin issue-1
    git push origin issue-2

    Repeat this process for each branch.

  4. Create Pull Requests:
    Now, you can create pull requests for each branch. On the GitHub repository, you'll see an option to create a pull request when you push a new branch. Follow the prompts to create a pull request for each issue.

By following these steps, you'll have separate branches for each issue with the relevant commits, and you can create individual pull requests for each issue.

@Prater-12 Prater-12 added backend Related to the backend author-action-required The PR's author is required to resolve issues labels Oct 28, 2023
@Prater-12 Prater-12 linked an issue Oct 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-action-required The PR's author is required to resolve issues backend Related to the backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accounts: Normalize roll number to ensure uniformity
2 participants