Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang-10 support #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjornstromberg
Copy link

  • added preprocessor directives to:
    • support for clang/llvm >= 10 which uses smartptr's instead of rawpointers.
    • support for clang/llvm < 10 which uses raw pointers.
    • bump required C++ version from 11 to 14,
      since Clang-10 requires C++14 to build, and clang-9 builds fine with it.

tested so it builds fine with clang-9 + clang-10.

  - support for clang/llvm >= 10 which uses smartptr's instead of rawpointers.
  - support for clang/llvm < 10 which uses raw pointers.
  - bump required C++ version from 11 to 14,
    since Clang-10 requires C++14 to build, and clang-9 builds fine with it.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bjornstromberg
Copy link
Author

well i wont sign any CLA, i'm no lawyer and i don't care that much to read into the agreement.
I've made the changes public on github, should be sufficent for GPLv3.

so i guess that will make this upstream pull request will never get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants