Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests for upcoming dependency version policy #1004

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Update unit tests for upcoming dependency version policy #1004

merged 3 commits into from
Oct 23, 2023

Conversation

lsinger
Copy link
Contributor

@lsinger lsinger commented Oct 23, 2023 •
edited
Loading

This PR updates our CI to ensure unit tests run with the WordPress and PHP versions that we'll require in our upcoming L-2 dependency version policy.

To test:

  • ensure CI passes
  • ensure the versions in the file conform to the L-2 policy -- also see here, we want to support WordPress latest minus 2 versions and the respective minimum PHP versions

@lsinger lsinger self-assigned this Oct 23, 2023
@lsinger lsinger requested review from a team and coreymckrill and removed request for a team October 23, 2023 15:59
coreymckrill
coreymckrill approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, and the tests have all passed.

@coreymckrill coreymckrill merged commit d7aa791 into trunk Oct 23, 2023
44 checks passed
@coreymckrill coreymckrill deleted the update/unit-tests-wordpress-php-versions branch October 23, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreymckrill coreymckrill coreymckrill approved these changes

Assignees

@lsinger lsinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsinger @coreymckrill