Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues reported by PCP (Plugin Check Plugin) #1030

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

jorgeatorres
Copy link
Member

@jorgeatorres jorgeatorres commented Feb 15, 2024

This PR fixes a few violations reported by the Plugin Check Plugin (PCP) from wporg's plugin team. In particular it addresses issues issues in all categories from PCP except for "Security" (which I'm still looking into).

The aim here is to improve compliance with the wporg review process, not to fix all issues with our codebase (of which there are still quite a few).

Related to #1027.

Testing instructions

  1. Make sure things are working ok. IMHO it should be enough to make sure tests pass, but some smoke testing wouldn't hurt.
  2. To make sure issues reported by PCP are fixed:
    1. Install "Plugin Check Plugin" in Plugins > Add New Plugin.
    2. Go to Tools > Plugin Check.
    3. Choose "Action Scheduler".
    4. Check off all categories except for "Security".
    5. Click "Check it!".
    6. Make sure violations reported are either in tests or false positives.

@jorgeatorres jorgeatorres requested review from a team and Konamiman and removed request for a team February 15, 2024 00:44
@Konamiman Konamiman merged commit 65b0d73 into trunk Feb 22, 2024
32 checks passed
@Konamiman Konamiman deleted the pcp/misc-fixes branch February 22, 2024 13:47
@lsinger lsinger added this to the 3.7.3 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants