Fix option lock test #995
Merged
Fix option lock test #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsinger
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Looks good to me. 
Two of the unit test runs are failing because WordPress 6.3 requires PHP 7+, which is of course unrelated to this PR. I'll open a separate issue for that.
Thanks! Yes, and we also need to make it possible to run the tests under 8.2 (but that's yet another problem...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of items (thank you @lsinger for raising awareness!):
Worth calling out: I'm deliberately suppressing database errors (but only temporarily). Without the suppression, if you run the test suite locally, you will notice unwanted noise in the output:
If there are any concerns with this, let me know.