Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Picker: Add tracking for list editing #14762

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Dec 24, 2024

Part of #14658

Description

This PR adds tracking for the store picker update project:

Event Trigger Properties
*_site_picker_edit_button_shown When the Edit button is available on the site picker.
*_site_picker_edit_button_tapped When the user taps the Edit button on the top right.
*_site_picker_list_save_button_tapped When the user taps the Save button on the edit store list screen hidden_site_count
*_site_picker_list_saving_success When saving is successful
*_site_picker_list_saving_failure When saving faills Error details

Steps to reproduce

  • Build and run the app on a physical device.
  • Log in to an account connected to more than one store.
  • Navigate to Menu > Store Picker.
  • Confirm that site_picker_edit_button_shown is tracked only once.
  • Select the Edit button, confirm that site_picker_edit_button_tapped is tracked.
  • De-select one or more stores in the list and tap Save. Confirm that site_picker_list_save_button_tapped is tracked with the correct value for hidden_site_count.
  • After the saving succeeds, confirm that site_picker_list_saving_success is tracked.
  • Disconnect the internet connection on the device and select Edit > update the selection > Save again.
  • Confirm that site_picker_list_saving_failure is tracked with error details.

Testing information

Tested on iPhone 16 Pro iOS 18.1 and confirmed that tracking work as expected.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. category: tracks Related to analytics, including Tracks Events. labels Dec 24, 2024
@itsmeichigo itsmeichigo added this to the 21.4 milestone Dec 24, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 24, 2024

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14762-ca41060
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitca41060
App Center BuildWooCommerce - Prototype Builds #12287
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review December 24, 2024 07:15
Base automatically changed from task/14658-update-notification-settings to trunk December 25, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants