Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some warnings #14763

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Resolve some warnings #14763

wants to merge 4 commits into from

Conversation

bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented Dec 24, 2024

Description

Resolved some Xcode warnings

  • unused variables
  • extra whitespaces
  • etc.

There are many more warnings left, most of them from things being deprecated, but that can be done in a separate PR.

Testing information

  • Make sure CI passes

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@bozidarsevo bozidarsevo added the type: enhancement A request for an enhancement. label Dec 24, 2024
@bozidarsevo bozidarsevo added this to the 21.4 milestone Dec 24, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 24, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14763-a42b480
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commita42b480
App Center BuildWooCommerce - Prototype Builds #12289
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@bozidarsevo bozidarsevo marked this pull request as ready for review December 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants