[크리스마스 프로모션] 신창혁 미션 제출합니다. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeanOfRedStone
referenced
this pull request
in MeanOfRedStone/java-christmas-6
Nov 25, 2023
1. ReservationDate 객체 생성 - 해당 도메인을 통해 날짜 유효성 검사를 받는 것으로 변경 - validateReservationDate() 1 ~ 31일 사이의 날짜가 아니면 IllegalArgumentException 발생 2. InputView 수정 - readDate() int date로 날짜를 받지 않고 ReservationDate의 객체를 통해 날짜를 입력받음 - validateDate() 삭제 객체의 로직으로 옮김 -> 해당 클래스 내 메소드는 Input에 집중하도록 바꿈 3. ChristmasController - 날짜를 int로 받지 않고 객체 ReservationDate를 통해 입력받음 -> 도메인을 더 알아보기 쉽게하기 위해
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ PR 타입
☄️ 반영 브랜치
🗺️ 클래스 다이어그램