Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#568 useModal을 사용한 부분을 overlay로 변경 #569

Merged
merged 4 commits into from
May 12, 2024
Merged

Refactor/#568 useModal을 사용한 부분을 overlay로 변경 #569

merged 4 commits into from
May 12, 2024

Conversation

cruelladevil
Copy link
Collaborator

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명(이미지 첨부 가능)

useModal 훅을 사용한 부분에서 변경할 수 있는 부분을 useOverlay를 활용

#️⃣연관된 이슈

연관된 이슈 번호를 모두 작성

close #568

@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2024 •
edited
Loading

Unit Test Results

  98 files    98 suites   10s ⏱️
389 tests 388 ✔️ 1 💤 0 ❌
394 runs  393 ✔️ 1 💤 0 ❌

Results for commit d5ac744.

♻️ This comment has been updated with latest results.

@cruelladevil cruelladevil self-assigned this May 12, 2024
@cruelladevil cruelladevil added [ 🌞 FE ] 프론트엔드 크루들의 빛나는 개발 이야기 하나둘셋 호! 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다 labels May 12, 2024
@cruelladevil cruelladevil merged commit 4c6a317 into main May 12, 2024
4 checks passed
@cruelladevil cruelladevil deleted the refactor/#568 branch May 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Creative-Lee Creative-Lee Awaiting requested review from Creative-Lee Creative-Lee is a code owner

@ukkodeveloper ukkodeveloper Awaiting requested review from ukkodeveloper ukkodeveloper is a code owner

Assignees

@cruelladevil cruelladevil

Labels
[ 🌞 FE ] 프론트엔드 크루들의 빛나는 개발 이야기 하나둘셋 호! 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] useModal을 사용한 부분을 overlay로 변경
1 participant
@cruelladevil