Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with a missing "Mark as Unread" button in the More menu #23917

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 20, 2024

Fixes #23916.

Changes:

  • Revert the change that removed the "Mark as Read/Unread" button from the post "More" menu
  • Add an understated "Read" indicator in the list (new feature)

This change applies to P2s. I don't think regular blogs support this.

To test:

  • Verify that the post you read have a checkmark in the lsit
  • Verify that after you open an unread post and return to the list, it shows the checkmark
  • Verify that you can toggle the "read" status using the "more" menu and that it updates state on the web

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Dec 20, 2024
@kean kean requested a review from crazytonyli December 20, 2024 17:20
@kean kean added this to the 25.6 ❄️ milestone Dec 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 20, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean changed the title Fix/toggle seen missing Fix an issue with a missing "Mark as Unread" button in the More menu Dec 20, 2024
@kean kean enabled auto-merge December 20, 2024 17:23
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23917-d21ea43
Version25.6
Bundle IDorg.wordpress.alpha
Commitd21ea43
App Center BuildWPiOS - One-Offs #11218
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23917-d21ea43
Version25.6
Bundle IDcom.jetpack.alpha
Commitd21ea43
App Center Buildjetpack-installable-builds #10256
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader: Mark as Unseen
3 participants