Replace WPImageViewController with LightboxViewController #23922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kean
commented
Dec 24, 2024
| @@ -145,6 +147,14 @@ final class AsyncImageView: UIView { | |||
| self.errorView = errorView | |||
| return errorView | |||
| } | |||
|
|
|||
| override func hitTest(_ point: CGPoint, with event: UIEvent?) -> UIView? { | |||
| if configuration.passTouchesToSuperview && self.bounds.contains(point) { | |||
There was a problem hiding this comment.
This was needed to make it work in WPRichTextImage (UIControl, needed to pass gestures to the superview)
kean
commented
Dec 24, 2024
| @@ -43,26 +35,8 @@ open class WPRichTextImage: UIControl, WPRichTextMediaAttachment { | |||
| addSubview(imageView) | |||
| } | |||
|
|
|||
| required public init?(coder aDecoder: NSCoder) { | |||
There was a problem hiding this comment.
The encoding was not used anywhere.
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23922-9e82544 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9e82544 | |
| App Center Build | WPiOS - One-Offs #11225 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23922-9e82544 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9e82544 | |
| App Center Build | jetpack-installable-builds #10263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
LightboxViewControllerto replaceWPImageViewController(Objective-C). The new screen usesImageDownloaderand also supports the zoom transitions introduced in iOS 18.media-after.mov
Here's how it used to look: before.
Changes
LightboxViewController(currently only supports one item at a time like the previous ViewController did)WPRichTextImageto useAsyncImageView(tested manually)PostFeaturedImageCellfrom Objective-C to Swift and removeImageLoaderusagesFeaturedImageViewController(Objective-C) and use natively provided toolbar insteadWPImageViewControllerRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: