Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump solana and anchor versions so unit tests work again #1

Closed
wants to merge 3 commits into from

Conversation

nonergodic
Copy link
Contributor

@nonergodic nonergodic commented Mar 15, 2024

  • bump Solana version to 1.18.6 (this is a testnet release! I couldn't get things to work with the latest "stable" release because it simply won't built - the jokes truly write themselves)
  • bump Anchor version to 0.29
  • pull in pythnet_sdk merkle tree and related code and make it compatible with the above versions

Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2024

Deploying example-grant-program with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4429598
Status:🚫  Build failed.

View logs

Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. My only comment would be to split the commits for the pythnet_sdk_cpy so that it's easier for security to review the diff.

M-Picco pushed a commit that referenced this pull request Mar 15, 2024
* Scaffolding

* Fix compilation

* Add formatting
@nonergodic
Copy link
Contributor Author

We can also decide to just stick with the original versions and just build with the environment defined in .github/workflows/token-dispenser.yml which is supposed to work too.

Haven't looked into potential pros/cons of that decision. I'm mainly using this branch as my local build/test branch to cherry-pick other commits into and ensure that they work as expected.

@nik-suri nik-suri closed this Mar 18, 2024
@nonergodic nonergodic deleted the update-versions-to-fix-tests branch March 23, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants