Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Modal #62

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Error Modal #62

merged 12 commits into from
Apr 2, 2024

Conversation

timpau
Copy link
Collaborator

@timpau timpau commented Apr 1, 2024

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 1, 2024 •
edited
Loading

Deploying example-grant-program with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e7baa9
Status:🚫  Build failed.

View logs

sebastianscatularo
sebastianscatularo reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@sebastianscatularo sebastianscatularo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, would be good to gets the user back to re start the process over the txs that has failed

frontend/components/modal/ErrorModal.tsx Show resolved Hide resolved
frontend/components/modal/ErrorModal.tsx Show resolved Hide resolved
frontend/components/modal/ErrorModal.tsx Outdated Show resolved Hide resolved
@M-Picco M-Picco merged commit 00f1ceb into main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianscatularo sebastianscatularo sebastianscatularo left review comments

@M-Picco M-Picco M-Picco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timpau @sebastianscatularo @M-Picco