-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: add more tests #219
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More tests are always great! Looks likes this needs a rebase.
After that I'll do a proper review. I'm sure adding tests will only be beneficial though so expect an approval
I'll rebase this later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR has some conflicts to be resolved
fb22598
to
8abb41f
Compare
@johnsaigle rebased! |
@kcsongor Clippy is unhappy |
8abb41f
to
71dcc38
Compare
9afb236
to
88c0cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: I committed this change directly to the branch.
CI is failing because of existing panic
calls in programs/example-native-token-transfers/tests/common/setup.rs.
I think this is somehow related to the rust-toolchain
change? If I change to stable
the panic is not flagged.
Anyway, I think you can add #[allow(clippy::panic)]
just above the failing code block and it should resolve the issue
88c0cbc
to
0ea2454
Compare
c5ad035
to
c2ebec3
Compare
@kcsongor A couple of notes:
Interestingly, the test actually passes if (I opened #336 in the process of trying to debug this. Take a look, maybe it'll help you) |
No description provided.