-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bing/ft swap monitor #349
Merged
Merged
Bing/ft swap monitor #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
13 times, most recently
from
August 7, 2024 03:59
e1dd63a
to
b2aafbf
Compare
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
from
August 7, 2024 12:21
b2aafbf
to
5d50960
Compare
panoel
reviewed
Aug 7, 2024
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
from
August 7, 2024 14:03
5d50960
to
3f774c1
Compare
panoel
reviewed
Aug 7, 2024
panoel
reviewed
Aug 7, 2024
panoel
reviewed
Aug 7, 2024
panoel
reviewed
Aug 7, 2024
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
4 times, most recently
from
August 7, 2024 15:35
dd540de
to
1a5b2fb
Compare
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
3 times, most recently
from
August 7, 2024 15:46
b61f268
to
b449da1
Compare
test: initial swap monitor testing ft_swap: parse redeem params to get fill vaa add id for redeem event ft_watcher: parse swap event and input ft_watcher: plug swap layer into ft watcher Signed-off-by: bingyuyap <[email protected]>
bingyuyap
force-pushed
the
bing/ft-swap-monitor
branch
from
August 7, 2024 15:48
b449da1
to
4b61502
Compare
panoel
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds swap layer parsing for Redeem transactions which allows us to:
The ID of a
redeem_swap
isfill_vaa_id
which is generated in theexecute_fast_transfer_*
stages. Another PR will be opened to add thefill_vaa_id
in the these stages.Note: that the swap layer is not deployed on
devnet
(as we need mainnet quotes from dexes we will test on mainnet) hence the need for mocked data in the test and lack thereof test for getting swap transactions within range. These will be added once the mainnet deployment is done.