Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watcher: add berachain and snaxchain #351

Merged
merged 2 commits into from
Aug 8, 2024
Merged

watcher: add berachain and snaxchain #351

merged 2 commits into from
Aug 8, 2024

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Aug 7, 2024

No description provided.

@panoel panoel marked this pull request as ready for review August 7, 2024 20:48
@panoel panoel requested a review from evan-gray August 7, 2024 20:48
evan-gray
evan-gray reviewed Aug 8, 2024
View reviewed changes
common/src/nttConsts.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
evan-gray
evan-gray requested changes Aug 8, 2024
View reviewed changes
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeTotalSupplyAndLocked.ts Outdated Show resolved Hide resolved
@panoel panoel force-pushed the add_berachain_and_snaxchain_watchers branch from 4d33836 to e93416c Compare August 8, 2024 13:34
@panoel panoel requested a review from evan-gray August 8, 2024 13:35
@panoel panoel mentioned this pull request Aug 8, 2024
Closed
evan-gray
evan-gray requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a better approach to refine these types. I gave some examples.

common/src/nttConsts.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeTotalSupplyAndLocked.ts Outdated Show resolved Hide resolved
common/src/nttConsts.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeTotalSupplyAndLocked.ts Outdated Show resolved Hide resolved
common/src/nttConsts.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeNTTRateLimits.ts Outdated Show resolved Hide resolved
evan-gray
evan-gray requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, super close.

cloud_functions/src/computeTotalSupplyAndLocked.ts Outdated Show resolved Hide resolved
cloud_functions/src/computeTotalSupplyAndLocked.ts Outdated Show resolved Hide resolved
common/src/nttConsts.ts Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Aug 8, 2024
View reviewed changes
common/src/nttConsts.ts Outdated Show resolved Hide resolved
@panoel panoel force-pushed the add_berachain_and_snaxchain_watchers branch 2 times, most recently from e4dd48b to 86417fb Compare August 8, 2024 18:33
@panoel panoel requested a review from evan-gray August 8, 2024 18:41
@evan-gray evan-gray force-pushed the add_berachain_and_snaxchain_watchers branch from 86417fb to 41081c3 Compare August 8, 2024 19:04
@panoel panoel merged commit 534cda6 into main Aug 8, 2024
3 checks passed
@panoel panoel deleted the add_berachain_and_snaxchain_watchers branch August 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panoel @evan-gray