Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ilariae/token bridge #96

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Ilariae/token bridge #96

wants to merge 45 commits into from

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Sep 23, 2024

Description

Added Build > Contract integrations > Get started with Token bridge page
Heavily updated Learn > Messaging > Token Bridge page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Sep 23, 2024
@eshaben eshaben requested a review from martin0995 September 27, 2024 00:46
eshaben
eshaben reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got a little way through and it started looking off to me. This guide should be about creating a contract that interacts with the token bridge directly, instead of JavaScript

build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
eshaben
eshaben reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the Learn section content this time around. Huge improvement there! Nice job!

learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
@ilariae ilariae marked this pull request as ready for review December 17, 2024 14:49
@ilariae ilariae requested a review from eshaben December 17, 2024 14:50
dawnkelly09
dawnkelly09 requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nice. Don't worry, a lot of these changes are the curved apostrophes ;-)

build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
@ilariae ilariae requested a review from dawnkelly09 December 19, 2024 13:13
dawnkelly09
dawnkelly09 reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my question about the index page card on /build/contract-integrations. If that is happening under a separate PR, then this is ready

build/contract-integrations/token-bridge.md Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got confused between the build content and learn content. Disregard!

@ilariae ilariae requested a review from dawnkelly09 December 20, 2024 11:33
dawnkelly09
dawnkelly09 previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

eshaben
eshaben reviewed Dec 23, 2024
View reviewed changes
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
@ilariae ilariae requested a review from eshaben December 23, 2024 15:25
@ilariae
Copy link
Collaborator Author

ilariae commented Dec 23, 2024

leaving a comment to remind myself to add the index card for this page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawnkelly09 dawnkelly09 dawnkelly09 left review comments

@martin0995 martin0995 Awaiting requested review from martin0995

@eshaben eshaben Awaiting requested review from eshaben

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilariae @eshaben @dawnkelly09