libraries/BytesParsing: don't check bounds in asAddressUnchecked #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonergodic
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Blerg... clearly, I just copy-pasted that at the time and forgot to go back and fix it, seeing how bool had the exact same issue. So sloppy 😬
(I assume the analogously erroneous asUint8 in asBoolUnchecked here is because the other PR that fixes it hasn't been merged yet.)
|
that's right, will take a loot at that shortly so we can merge. also, what's happening with the failing test? seems unrelated |
beats me, seems unrelated indeed |
|
triggered a rebuild on |
nonergodic
force-pushed
the
address-unchecked
branch
from
45bf248
to
ac04d08
Compare
nonergodic
force-pushed
the
address-unchecked
branch
from
ac04d08
to
3943fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.