-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clients/js: add worm cli tests (parse, recover, info) + worm submit (testing all chains) #3229
Closed
AlberErre
wants to merge
240
commits into
wormhole-foundation:main
from
AlberErre:clients/js/test-worm-cli-submit-all-chains
Closed
clients/js: add worm cli tests (parse, recover, info) + worm submit (testing all chains) #3229
AlberErre
wants to merge
240
commits into
wormhole-foundation:main
from
AlberErre:clients/js/test-worm-cli-submit-all-chains
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlberErre
force-pushed
the
clients/js/test-worm-cli-submit-all-chains
branch
from
August 14, 2023 12:02
79b542a
to
c0e1d2e
Compare
Same / duplicate of #2631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2596
This PR adds unit tests for
cmds
commands on worm CLI located onclient/ts/__tests__
Functionality tests added (to cover all cases dynamically):
worm submit
(all chains), as discussed on [Worm CLI] Implement testing for worm submit command (ContractUpgrade case) #3196worm parse
worm recover
worm info chain-id
worm info rpc
worm info contract
A Github Actions (
.github/workflows/worm-cli.yml
) has been created to integrate all these tests & build process into wormhole pipelines 🚀Also, a
jest.config.json
file has been added to configurejest
testing environment.MSW
In order to test
worm submit
functionality, a mocking network utility tool has been used msw.js.This tool captures the network calls made in
jest
testing environment. Then each test verifies the transaction HTTP calls has been made for each chain case, testing both positive cases (happy path, sends transaction to network) and negative cases (wrong VAA submitted for worm submit command).How to run
Navigate to
client/js
folder:Local configuration
worm submit
to work properly).Set ENV variables on your local machine by running the following command:
Run tests