-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cw wormhole interchain tests #4189
base: main
Are you sure you want to change the base?
Conversation
7714357
to
9f3be80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with just a couple changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified that this change only affects non-functional testing code.
Adds an interchain test which runs tests against the core contract on Wormchain. It tests the query and execution endpoints within the contract (both happy and error paths). Also, these tests will run in GitHub workflows.
Side Note
Looks like the whitepaper and the actual implementation of the TransferFees VAA do not align. In the whitepaper, it states that the payload should be structured as so: whitepaper. However, the implementation within the rust contract swaps the amount and recipient's order within the byte array: contract.