Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cw wormhole interchain tests #4189

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

joelsmith-2019
Copy link
Collaborator

@joelsmith-2019 joelsmith-2019 commented Dec 12, 2024

Adds an interchain test which runs tests against the core contract on Wormchain. It tests the query and execution endpoints within the contract (both happy and error paths). Also, these tests will run in GitHub workflows.

Side Note
Looks like the whitepaper and the actual implementation of the TransferFees VAA do not align. In the whitepaper, it states that the payload should be structured as so: whitepaper. However, the implementation within the rust contract swaps the amount and recipient's order within the byte array: contract.

@joelsmith-2019 joelsmith-2019 self-assigned this Dec 12, 2024
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review December 12, 2024 21:19
@joelsmith-2019 joelsmith-2019 force-pushed the chore/add-cw_wormhole-integration-tests branch from 7714357 to 9f3be80 Compare December 12, 2024 21:20
@joelsmith-2019 joelsmith-2019 changed the title chore: add wormchain core contract interchain tests chore: add cw wormhole interchain tests Dec 13, 2024
Copy link
Collaborator

@kakucodes kakucodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with just a couple changes.

cosmwasm/schema/wormhole-cosmwasm.json Outdated Show resolved Hide resolved
wormchain/interchaintest/cw_wormhole_test.go Outdated Show resolved Hide resolved
@kakucodes kakucodes self-requested a review December 18, 2024 20:07
Copy link
Collaborator

@kakucodes kakucodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that this change only affects non-functional testing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants