Workaround instant disconnect issue for whispers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meorawr
added
bug
This works around an instant disconnect bug with SendAddonMessage when sending whispers to players whose combined "character-realm" name appears to exceed this threshold, most easily noticed with players from Russian realms. As the issue is being actively fixed, hopefully we don't need this workaround for too long - so a time bomb is included to disable it after about two weeks in the event a user doesn't update. This is only applied to "smart" messages, as those are the only ones guaranteed to be "name-realm" qualified.
Meorawr
force-pushed
the
patch/disconnect-workaround
branch
from
dcd0f88
to
cecf3c2
Compare
Solanya
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an instant disconnect bug with SendAddonMessage when sending whispers to players whose combined "character-realm" name appears to exceed this threshold, most easily noticed with players from Russian realms. See Stanzilla/WoWUIBugs#573.
As the issue is being actively fixed, hopefully we don't need this workaround for too long - so a time bomb is included to disable it after about two weeks in the event a user doesn't update.
This is only applied to "smart" messages, as those are the only ones guaranteed to be "name-realm" qualified.