Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tiers upgrade feature - Base PR #7197

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented Dec 19, 2024

Description

Fixes https://github.com/wp-media/wp-rocket.me/issues/4326

Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

Everything is mentioned in the issue, the service team changed the API to return the available upgrades and we used that without doing any calculations on the plugin side.

Technical description

Documentation

Everything is mentioned in the issue and sub-issues.

New dependencies

Now we depend on the new API, so we need to make sure that we release the API to the production site one day before releasing this change in plugin because we save the user API for one day.

Update: Now we have the API changes live.

Risks

We need to validate also the upgrade process with older versions of the plugins to make sure they are working.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9acceae1 90.48% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9acceae) Report Missing Report Missing Report Missing
Head commit (d11aced) 38231 16727 43.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7197) 84 76 90.48%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan wordpressfan marked this pull request as ready for review December 20, 2024 09:38
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Dec 20, 2024

@wordpressfan Thanks for the PR.
Note:

  • the arrow in the upgrade button is small and not centralized
  • the selected option in multi can be highlighted when open the dropdown
    will leave it to @wp-media/product to share reference UI
    @marija-nikolic Please check the UI of different forms
    Upgrade from multi 100
    Screenshot from 2024-12-20 13-47-57

upgrade from multi 50
Screenshot from 2024-12-20 12-58-21
Screenshot from 2024-12-20 12-56-27
Screenshot from 2024-12-20 12-56-17

upgrade from growth
Screenshot from 2024-12-20 14-03-01
Screenshot from 2024-12-20 14-02-55
Screenshot from 2024-12-20 14-02-48
Screenshot from 2024-12-20 14-02-41

upgrade from single
Screenshot from 2024-12-20 12-52-07
Screenshot from 2024-12-20 13-59-10
Screenshot from 2024-12-20 13-59-02

No upgrade for multi500
Screenshot from 2024-12-20 14-18-21

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Dec 20, 2024

Promo banner
for single
Screenshot from 2024-12-20 14-48-04
Screenshot from 2024-12-20 14-47-54
Screenshot from 2024-12-20 14-47-13
Screenshot from 2024-12-20 14-46-57

for plus
Screenshot from 2024-12-20 14-51-07
Screenshot from 2024-12-20 14-51-00
Screenshot from 2024-12-20 14-50-53
Screenshot from 2024-12-20 14-50-45

for growth
Screenshot from 2024-12-20 14-52-49
Screenshot from 2024-12-20 14-52-43
Screenshot from 2024-12-20 14-52-36
Screenshot from 2024-12-20 14-52-29

for multi 50
Screenshot from 2024-12-20 14-54-19
Screenshot from 2024-12-20 14-54-08
Screenshot from 2024-12-20 14-54-02

for multi100

Screenshot from 2024-12-20 14-55-25

Screenshot from 2024-12-20 15-01-54

multi 500, no promo
Screenshot from 2024-12-20 15-04-18

@marija-nikolic
Copy link
Collaborator

Congrats, team, everything seems good to me. 👏
I agree with what @Mai-Saad wrote:

  • the arrow in the upgrade button is small and not centralized
  • the selected option in multi can be highlighted when open the dropdown

Only one small thing: it should be written Growth or Multi on the yellow banner:
image

@Mai-Saad Mai-Saad added this to the 3.17.4 milestone Dec 23, 2024
@Mai-Saad
Copy link
Contributor

testrail-report-676.pdf

@Khadreal
Copy link
Contributor

Screenshot

Fixed the copy on the yellow banner
Screenshot 2024-12-24 at 23 23 55
Aligned arrow
Screenshot 2024-12-24 at 23 24 43
Screenshot 2024-12-24 at 23 27 57

cc @Mai-Saad, @marija-nikolic

@marija-nikolic
Copy link
Collaborator

Screenshot

Fixed the copy on the yellow banner Screenshot 2024-12-24 at 23 23 55 Aligned arrow Screenshot 2024-12-24 at 23 24 43 Screenshot 2024-12-24 at 23 27 57

cc @Mai-Saad, @marija-nikolic

Thanks, looks good.

@wordpressfan
Copy link
Contributor Author

So we are fine here, thanks @Khadreal @marija-nikolic @Mai-Saad

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9acceae1 90.48% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9acceae) Report Missing Report Missing Report Missing
Head commit (35a3a06) 38231 16727 43.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7197) 84 76 90.48%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants