-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi tiers upgrade feature - Base PR #7197
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
@wordpressfan Thanks for the PR.
|
Congrats, team, everything seems good to me. 👏
Only one small thing: it should be written |
So we are fine here, thanks @Khadreal @marija-nikolic @Mai-Saad |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Description
Fixes https://github.com/wp-media/wp-rocket.me/issues/4326
Explain how this code impacts users.
Type of change
Detailed scenario
Everything is mentioned in the issue, the service team changed the API to return the available upgrades and we used that without doing any calculations on the plugin side.
Technical description
Documentation
Everything is mentioned in the issue and sub-issues.
New dependencies
Now we depend on the new API, so we need to make sure that we release the API to the production site one day before releasing this change in plugin because we save the user API for one day.
Update: Now we have the API changes live.
Risks
We need to validate also the upgrade process with older versions of the plugins to make sure they are working.
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks