Only add extensions in module file if there are extensions

This fixes easybuilders#4330.
wpoely86 · Aug 30, 2023 · f725ac2 · f725ac2
1 parent ac91659
commit f725ac2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/easybuild/tools/module_generator.py b/easybuild/tools/module_generator.py
@@ -622,7 +622,8 @@ def _generate_extensions_list(self):
         """
         Generate a list of all extensions in name/version format
         """
-        return self.app.make_extension_string(name_version_sep='/', ext_sep=',').split(',')
+        exts_str = self.app.make_extension_string(name_version_sep='/', ext_sep=',')
+        return exts_str.split(',') if exts_str else []
 
     def _generate_help_text(self):
         """

diff --git a/test/framework/module_generator.py b/test/framework/module_generator.py
@@ -756,6 +756,16 @@ def test_module_extensions(self):
             regex = re.compile(pattern, re.M)
             self.assertTrue(regex.search(desc), "Pattern '%s' found in: %s" % (regex.pattern, desc))
 
+        # check if the extensions is missing if there are no extensions
+        test_ec = os.path.join(test_dir, 'easyconfigs', 'test_ecs', 't', 'toy', 'toy-0.0-test.eb')
+
+        ec = EasyConfig(test_ec)
+        eb = EasyBlock(ec)
+        modgen = self.MODULE_GENERATOR_CLASS(eb)
+        desc = modgen.get_description()
+
+        self.assertFalse(re.search(r"\s*extensions\(", desc), "No extensions found in: %s" % desc)
+
     def test_prepend_paths(self):
         """Test generating prepend-paths statements."""
         # test prepend_paths