Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLAG-1193] Error in the query of TCL widget within some custom areas #4853

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

willian-viana
Copy link
Collaborator

Overview

The query of the widgethttps://gfw.global/4e4K0Xq, has undefined for the year, likely from an undefined JavaScript variable:

Demo

Screenshot 2024-09-20 at 16 11 26

Without it, the first params object won't have these properties and will break the chart
Now when the user change extent year option, the query will be updated
@willian-viana willian-viana self-assigned this Sep 20, 2024
@willian-viana willian-viana marked this pull request as ready for review September 20, 2024 19:11
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4853 September 20, 2024 19:15 Inactive
Copy link
Collaborator

@wri7tno wri7tno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@willian-viana willian-viana merged commit 28909d2 into develop Sep 23, 2024
4 checks passed
@willian-viana willian-viana deleted the fix/TCL-query-FLAG-1193 branch September 23, 2024 14:54
@willian-viana willian-viana mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants