Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBTEL interface refactor #99

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

EBTEL interface refactor #99

wants to merge 5 commits into from

Conversation

wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Oct 15, 2024

Fixes #95

This reorganizes the EBTEL model interface to use the newly-reorganized ebtel++ Python interface. It also significantly refactors and simplifies the heating models used with ebtel.

TODOs:

  • Tests for various heating models just to ensure they actually work (i.e. smoke tests)
  • Example gallery for EBTEL and an "interesting" heating model

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 79.07950% with 50 lines in your changes missing coverage. Please review.

Project coverage is 51.14%. Comparing base (c45f6aa) to head (b87f3d9).

Files with missing lines Patch % Lines
synthesizAR/interfaces/ebtel/nei.py 28.57% 25 Missing ⚠️
synthesizAR/interfaces/ebtel/heating_models.py 84.68% 17 Missing ⚠️
synthesizAR/models/heating.py 44.44% 5 Missing ⚠️
synthesizAR/interfaces/ebtel/ebtel.py 97.05% 1 Missing ⚠️
synthesizAR/interfaces/hydrad/hydrad.py 80.00% 1 Missing ⚠️
synthesizAR/strand.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   44.77%   51.14%   +6.36%     
==========================================
  Files          39       40       +1     
  Lines        2135     2100      -35     
==========================================
+ Hits          956     1074     +118     
+ Misses       1179     1026     -153     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor EBTEL interface
2 participants