-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isFlippedCropRect
option
#66
Conversation
Added isFlippedCropRect
@@ -40,7 +40,8 @@ public final class Aperture: NSObject { | |||
highlightClicks: Bool, | |||
screenId: CGDirectDisplayID = .main, | |||
audioDevice: AVCaptureDevice? = .default(for: .audio), | |||
videoCodec: String? = nil | |||
videoCodec: String? = nil, | |||
isFlippedCropRect: Bool? = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter needs to be documented in a doc comment. It should say what it does and what it's useful for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it's should not be an optional.
The code here is not compiling. Please ensure the code can compile and is working properly (that it actually correctly flips the crop rect). |
I think this needs a test. It can just be to run Aperture with certain options and generate a video file with a descriptive name that can be manually verified. |
Let us know if you want to continue working on this fix @JakeMakesStuff! |
Fixes #65