#201 #202
Closed
#201 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first ever contribution to any project hope so its right
banterCZ
requested changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks for the contribution. Unfortunately, this was not the point of the issue. See the field responseTimeout. It is a newer feature, which is a type of Duration and keeps both the amount and unit. Unlike connectionTimeout which keeps only the amount but the unit is a millisecond by convention. Also please see https://github.com/wultra/.github/blob/main/CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first ever contribution to any project hope so its right