Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use general encryptor for E2EE #423

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Use general encryptor for E2EE #423

merged 3 commits into from
Aug 24, 2023

Conversation

hvge
Copy link
Member

@hvge hvge commented Aug 11, 2023

This PR replaces usage of low level ECIES routines with ServerEncryptor implemented in wultra/powerauth-crypto#493

Notable API changes:

  • @PowerAuthEncryption annotation now use enum EncryptionScope provided by this library instead of low level crypto enum EciesScope.
  • EciesEncryptionContext renamed to EncryptionContext

petrdvorak
petrdvorak approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@petrdvorak petrdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hvge hvge requested a review from romanstrobl August 21, 2023 11:06
romanstrobl
romanstrobl approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, however we should fix the imports in several cases.

...curity/powerauth/rest/api/spring/annotation/support/PowerAuthEncryptionArgumentResolver.java Outdated Show resolved Hide resolved
...curity/powerauth/rest/api/spring/annotation/support/PowerAuthEncryptionArgumentResolver.java Outdated Show resolved Hide resolved
.../java/io/getlime/security/powerauth/rest/api/spring/filter/EncryptionResponseBodyAdvice.java Outdated Show resolved Hide resolved
@banterCZ banterCZ merged commit bc53a26 into develop Aug 24, 2023
4 checks passed
@banterCZ banterCZ deleted the issues/420-use-general-encryptor branch August 24, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

@petrdvorak petrdvorak petrdvorak approved these changes

@banterCZ banterCZ Awaiting requested review from banterCZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvge @petrdvorak @banterCZ @romanstrobl