fix: provider should be specified in the config.yaml #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oes-not-validate-schema-provider-id-is-valid-in-the
…-provider-id-is-valid-in-the
…oes-not-validate-schema-provider-id-is-valid-in-the
…-provider-id-is-valid-in-the
StarpTech
requested changes
Dec 11, 2024
| for _, ffConfig := range routerConfig.FeatureFlagConfigs.GetConfigByFeatureFlagName() { | ||
| for _, datasource := range ffConfig.EngineConfig.DatasourceConfigurations { | ||
| if customEvents := datasource.CustomEvents; customEvents != nil { | ||
| customEvents.DontVerify = true |
There was a problem hiding this comment.
I'm not sure why we need this flag. It is also not the right way to extend the node_pb definition when this information is set at the router.
There was a problem hiding this comment.
+1 why do we need to disable this validation?
The only case is when you don't have edfs configuration at all, but then buildPubSub configuration won't be called
If we really need such an option I would suggest to name it differently - smth like
DisableEventProviderIdExistenceValidation
Just something more describing an intent of that option
There was a problem hiding this comment.
Create a separate graph configuration without the EDFS graph. In that case, you don't have to deal with cross-concern issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When the providers needed by the router are not configured the router should not start, but return an error.
The control should be disableable when necessary; on all old tests, the check is disabled.
Checklist