This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Convert Drush aliases to Drush 9 syntax (fixes #326). #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormi
changed the title
tharna
suggested changes
Apr 4, 2019
| @@ -27,11 +27,11 @@ popd > /dev/null | |||
| # Parse project config | |||
| PROJECTCONF=$ROOT/conf/project.yml | |||
| eval $(parse_yaml $PROJECTCONF) | |||
| ALIASFILE=${project_name}.aliases.drushrc.php | |||
| ALIASTARGET=$HOME/.drush/$ALIASFILE | |||
| ALIASFILE=self.site.yml | |||
There was a problem hiding this comment.
Alias filename should be unique across projects, otherwise only the first one will work as later projects are unable to create their alias file.
| @@ -0,0 +1,51 @@ | |||
| # Docs at https://github.com/drush-ops/drush/blob/master/examples/example.site.yml | |||
|
|
|||
There was a problem hiding this comment.
Should there be Lando specific environment here as well?
There was a problem hiding this comment.
The lando drush command is the correct way to run drush inside lando. There should generally be no need to run drush on the host.
There was a problem hiding this comment.
Does this also work for running drush commands on remote servers?
evilfurryone
reviewed
Apr 4, 2019
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin | |||
There was a problem hiding this comment.
Would it make more sense to keep the old PATH as well or is this not important?
export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:$PATH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326.
Done
.lando.ymlbuild.shSetup.mdTodo
Questions