Sync Fork #2
Open
Sync Fork #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow staticcheck to run in GitHub Actions * Add .changes section to avoid CHANGELOG confilcts * Add current release note to CHANGELOG.md * Add links replacement script * Add documentation for .changes Signed-off-by: Giuseppe Maxia <[email protected]>
* Add structure needed to update storage profiles * Add methods to add/remove VDC storage profiles * Replace methods used to search storage profiles * Deprecate vdc.GetDefaultStorageProfileReference * Add tests for storage profile handling * Add CHANGELOG items Signed-off-by: Giuseppe Maxia <[email protected]>
Go 1.17 introduced changes to how build tags are defined. gofmt automatically fixes that and this PR is just to make sure we are 1.17 compatible so that make build works.
Add OwnerRef field to types.OpenAPIEdgeGateway
Add support for Provider part of NSX-T ALB configuration functions. These are required to configure VCD for usage of AVI load balancer (NSX-T ALB) Functionality includes 5 entities in total. 3 of them have CRUD functionality (some still do not support Update in VCD) and 2 Read-only entities used only for lookup of AVI Controller components for mapping in VCD. Note. This functionality requires VCD >= 10.2
* Add support and tests for external network backed by NSX-T Segment in 10.3
* Add CHANGELOG for 2.13.0 Signed-off-by: Giuseppe Maxia <[email protected]>
* Fix receiver name in code and comments Co-authored-by: Yuri crashiura Co-authored-by: Dainius <[email protected]> Co-authored-by: lvirbalas <[email protected]> Co-authored-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
…are#403) This PR starts adding NSX-T ALB support for Tenant view. It is in tenant view, but still requires System user (just like creating an edge gateway) This is the first resource in series to allow controlling ALB on NSX-T Edge Gateway. It still requires system user to modify, just as creating an edge gateway, but is presented in Tenants view
…Library (vmware#404) * added implementation for managing Certificates in certificate library. New functions and methods GetCertificateFromLibraryById, AddCertificateToLibrary, GetAllCertificatesFromLibrary, GetCertificateFromLibraryByName, Update, Delete * added handling different API calls for 10.2.0 and query issue in 10.2.2 * added space handling in alias
* Add method VCDClient.GetBearerTokenFromApiToken * Add method VCDClient.SetApiToken * Make VCDClient.SetToken accept API tokens transparently * Add tracer for token usage in client structure * Add check for API token usage in tests * Update logging of API token operations * Add removal of certificate details from logs Signed-off-by: Giuseppe Maxia <[email protected]>
* Remove warnings with url.ParseRequestURI * Resolve unchecked error warnings * Fix null pointer dereference * Remove dead code * Remove redundant Boolean return value Methods client.vcdCheckSupportedVersion, client.checkSupportedVersionConstraint, and client.apiVersionMatchesConstraint were returning "true" only if error was nil. Removing the Boolean returning value makes evaluation more streamlined. Signed-off-by: Giuseppe Maxia <[email protected]>
* Add connection info to govcd logs Signed-off-by: Giuseppe Maxia <[email protected]>
* Change refresh_token to use request body Although the operations in go-vcloud-director are logged with the sensitive information filtered off, when using the API token in the URL, it gets recorded in the VCD logs. To avoid this logging, which may result in token disclosure when a support bundle is generated, we change the refresh_token operation to use the request body instead of URL parameters. Signed-off-by: Giuseppe Maxia <[email protected]>
* Add VDC group implementation and tests * Add fix for roles.go * Add tests for org Admin * Add methods to handle default DFW policy Signed-off-by: Vaidotas Bauzys <[email protected]>
…e#418) * added bug fix after analyzing #728. Update internal disk would clean VM description Signed-off-by: Vaidotas Bauzys <[email protected]>
Introduce ALB Virtual Service management functions
* Add types for vApp lease management * Add methods vApp.RenewLease vApp.GetLease * Fix Issue vmware#421: Wrong XML name in VM params * Wrong XML name in SourcedVmTemplateParams: VMGeneralParams should be instead VmGeneralParams Signed-off-by: Giuseppe Maxia <[email protected]>
* add implementation for uploading OVF by link * add vApp template update function
* add PublishToExternalOrganizations for catalogs methods * change adminOrg.CreateCatalogWithStorageProfile return AdminCatalog with parent
* add fix for the test
* rename master to main * update links
* Add disk sharing functionality (v35.0) and UUID (v36.0)
* Add VM methods GetExtraConfig, UpdateExtraConfig, DeleteExtraConfig * Add Changelog entry --------- Signed-off-by: Giuseppe Maxia <[email protected]> Co-authored-by: Dainius Serplis <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: abarreiro <[email protected]>
…) (NAT, FW, Route Advertisement) (vmware#660)
Signed-off-by: abarreiro <[email protected]>
* Enable query for Organizations * Add types and basic methods to retrieve associations * Update cumulative query for Orgs * Add functions to get associations data from site and organization * Add methods to set and remove Org associations * Add functions to set/remove site associations * Add type Site * Add methods GetSite, CheckSiteAssociation, CheckOrgAssociation * Add full multi-site test * Add method AdminOrg.GetAllOpenApiOrgVdcNetworks * Add method client.GetAllOrgs for multi-site retrieval of organizations * Add changelog entry --------- Signed-off-by: Giuseppe Maxia <[email protected]> Co-authored-by: Roman Hochuli <[email protected]>
* Add Xmlns field to types.RequestVirtualHardwareSection * Force Xmlns value in input to updateExtraConfig --------- Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Create Changelog for v2.25.0 release --------- Signed-off-by: Giuseppe Maxia <[email protected]>
This reverts commit 9863413.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets us closer to even with the original SDK by dropping the addition of context. We update the types still to allow exposing the external IP and the description of the vApp.