[RGen] First inclusion of a roslyn generator for the bindings. #21389

mandel-macaque · 2024-10-08T19:45:44Z

We are doing the following:

Adding the rgen directory with the following solutions:
- Analyzer: Analyzer that will catch errors in the bindings. At the moment it provides a single error when the BindingTypeAttribute is used in a nont partial type.
- Analyzer Tests: Allows tests for the analyzer.
- Analyzer Sample: Sample project to test the analyzer.
- Code Generator: A code generator that adds the BindingTypeAttribute to the compilcation.
- Code Generator Tests: Allows tests for the generator.
- Code Sample: Sample project for the code generator.
Make rule to build the roslyn code generator.
Makefile changes to add the code generator as part as the second compilation of the bindings.

This changes add the starting gounds to move to roslyn.

We are doing the following: 1. Adding the rgen directory with the following solutions: * Analyzer: Analyzer that will catch errors in the bindings. At the moment it provides a single error when the BindingTypeAttribute is used in a nont partial type. * Analyzer Tests: Allows tests for the analyzer. * Analyzer Sample: Sample project to test the analyzer. * Code Generator: A code generator that adds the BindingTypeAttribute to the compilcation. * Code Generator Tests: Allows tests for the generator. * Code Sample: Sample project for the code generator. 2. Make rule to build the roslyn code generator. 3. Makefile changes to add the code generator as part as the second compilation of the bindings. This changes add the starting gounds to move to roslyn.

github-actions · 2024-10-08T19:49:35Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2024-10-08T19:50:41Z

src/rgen/Microsoft.Macios.Generator.Tests/BaseTestClass.cs

+	protected CSharpGeneratorDriver _driver;
+	protected PortableExecutableReference [] _references;
+	// HACK: this is a hack to get the runtime dll for the attributes
+	const string RuntimeDll = "/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/src/build/dotnet/ios/64/Microsoft.iOS.dll";


Ugh, I need to fix this for the tests. @haritha-mohan can you do the same trick you do with adr here?

src/Makefile

rolfbjarne

The tests should be executed when the generator/bgen tests are executed in xharness as well.

...n/Microsoft.Macios.Bindings.Analyzer.Sample/Microsoft.Macios.Bindings.Analyzer.Sample.csproj

...gen/Microsoft.Macios.Bindings.Analyzer.Tests/Microsoft.Macios.Bindings.Analyzer.Tests.csproj

rolfbjarne · 2024-10-09T06:40:02Z

src/rgen/Microsoft.Macios.Bindings.Analyzer.Tests/BindingTypeSyntaxAnalyzerTests.cs

@@ -0,0 +1,26 @@
+/*


Either remove or uncomment/fix.

rolfbjarne · 2024-10-09T06:40:23Z

src/rgen/Microsoft.Macios.Bindings.Analyzer.Tests/SampleCodeFixProviderTests.cs

@@ -0,0 +1,32 @@
+/*


Either remove or uncomment/fix.

rolfbjarne · 2024-10-09T06:41:12Z

src/rgen/Microsoft.Macios.Bindings.Analyzer/BindingTypeCodeFixProvider.cs

+/// A sample code fix provider that renames classes with the company name in their definition.
+/// All code fixes must  be linked to specific analyzers.


This comment is out of date.

src/rgen/Microsoft.Macios.Generator.Tests/Microsoft.Macios.Generator.Tests.csproj

src/rgen/Microsoft.Macios.Generator.Tests/BindingSourceGeneratorTests.cs

src/rgen/Microsoft.Macios.Generator/ExtraSources.cs

src/Makefile.rgenerator

src/Makefile

rolfbjarne

The tests should be executed when the generator/bgen tests are executed in xharness as well.

src/rgen/Microsoft.Macios.Generator.Sample/Microsoft.Macios.Generator.Sample.csproj

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

vs-mobiletools-engineering-service2 · 2024-10-10T00:09:23Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: cbeddc34fef102fa66bdf6cdea9dffda8ae9d6aa [PR build]

1. Allow the tests to use the compiled dlls for dotnet. 2. Added an example test for the code generator. 3. Added an example test for the analyzer. 4. Included the new test projects in xharness.

…arin-macios into dev/mandel/rgen-init-project

vs-mobiletools-engineering-service2 · 2024-10-15T15:40:06Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:47:58Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:54:27Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:56:15Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:58:08Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:15:46Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 100 tests passed.

Failures

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

mandel-macaque requested a review from rolfbjarne as a code owner October 8, 2024 19:45

Auto-format source code

ad8c2cb

mandel-macaque commented Oct 8, 2024

View reviewed changes

Merge branch 'main' into dev/mandel/rgen-init-project

e25bb24

mandel-macaque commented Oct 8, 2024

View reviewed changes

src/Makefile Outdated Show resolved Hide resolved

Update src/Makefile

5b21411

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Oct 9, 2024

View reviewed changes

mandel-macaque commented Oct 9, 2024

View reviewed changes

src/rgen/Microsoft.Macios.Generator.Sample/Microsoft.Macios.Generator.Sample.csproj Outdated Show resolved Hide resolved

Apply suggestions from code review

1c1af2b

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

This comment has been minimized.

Sign in to view

mandel-macaque and others added 2 commits October 9, 2024 17:20

Add tests to xharness so that they are added easily to the CI.

ab60198

Merge branch 'main' into dev/mandel/rgen-init-project

cbeddc3

This comment has been minimized.

Sign in to view

mandel-macaque added 4 commits October 10, 2024 13:27

Made the following changes to make working with the code easier:

c6d774f

1. Allow the tests to use the compiled dlls for dotnet. 2. Added an example test for the code generator. 3. Added an example test for the analyzer. 4. Included the new test projects in xharness.

Merge branch 'main' into dev/mandel/rgen-init-project

559d08d

Merge branch 'dev/mandel/rgen-init-project' of github.com:xamarin/xam…

687d09a

…arin-macios into dev/mandel/rgen-init-project

Fix docs.

b986a58

Add experimental ID and attr for the new rgen code.

8673fa5

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/rgen-init-project

7a35e2e

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Oct 15, 2024

View reviewed changes

mandel-macaque added 3 commits October 15, 2024 10:21

Do not document ctr that is automatic.

e76f120

Ignore ObjCBindings as a framework.

b39077c

Merge branch 'dev/mandel/rgen-init-project' of github.com:xamarin/xam…

dcd362b

…arin-macios into dev/mandel/rgen-init-project

mandel-macaque merged commit 0f35909 into main Oct 15, 2024
17 checks passed

mandel-macaque deleted the dev/mandel/rgen-init-project branch October 15, 2024 18:56

		/// A sample code fix provider that renames classes with the company name in their definition.
		/// All code fixes must be linked to specific analyzers.

[RGen] First inclusion of a roslyn generator for the bindings. #21389

[RGen] First inclusion of a roslyn generator for the bindings. #21389

Conversation

mandel-macaque commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

⚠️ Your code has been reformatted. ⚠️

mandel-macaque Oct 8, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

rolfbjarne Oct 9, 2024

Choose a reason for hiding this comment

rolfbjarne Oct 9, 2024

Choose a reason for hiding this comment

rolfbjarne Oct 9, 2024

Choose a reason for hiding this comment

rolfbjarne left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 10, 2024

🔥 [CI Build] Build failed 🔥

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (macOS)

Successes